feat(NcDialogButton): Allow to return false from callback to keep dialog open
#6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
3 tasks
st3iny
approved these changes
Aug 22, 2024
susnux
force-pushed
the
feat/allow-keep-dialog-open
branch
2 times, most recently
from
642f137
to
1001142
Compare
|
Added an example with loading buttons. |
susnux
force-pushed
the
feat/allow-keep-dialog-open
branch
from
1001142
to
3fbf2d8
Compare
ShGKme
approved these changes
Aug 30, 2024
susnux
force-pushed
the
feat/allow-keep-dialog-open
branch
3 times, most recently
from
ef493ec
to
f907fef
Compare
st3iny
approved these changes
Aug 31, 2024
…ialog open If the callback returns `false` then the click event will not be forwarded. This could be usful if the click triggers a validation that fails and the user should be able to fix the issue. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/allow-keep-dialog-open
branch
from
f907fef
to
4200009
Compare
|
/backport to next |
2 tasks
This was referenced Sep 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
If the callback returns
falsethen the click event will not be forwarded. This could be useful if the click triggers a validation that fails and the user should be able to fix the issue.🏁 Checklist
nextrequested with a Vue 3 upgrade